Add new or undescribed species function is broken

A historical forum for issues reported in the suggestions and bugs forum that have been subsequently fixed or resolved.
Post Reply
User avatar
bekateen
Posts: 7178
Joined: Tue Sep 09, 2014 5:50 pm
I've donated: $40.00!
My articles: 4
My images: 76
My cats species list: 111 (i:37, k:46)
My aquaria list: 29 (i:13)
My BLogs: 36 (i:125, p:1867)
My Wishlist: 39
Spotted: 136
Location 1: USA, California, Stockton
Location 2: USA, California, Stockton
Contact:

Add new or undescribed species function is broken

Post by bekateen »

Hi Jools,

Today I tried to add the new Microcambeva bendego to the CLOG. When I submitted the name I received the message "name not found" and a recommendation that I try adding new species (in other words, it circled me back to where I started).

Sorry,
Eric
Image
http://youtube.com/user/Bekateen1
Would you like to buy my fish? Click HERE for prices.
Buying caves from https://plecocaves.com? Plecocaves is now sponsoring Bekateen's Fishroom. Use coupon code "bekateen" (no quotes) for 15% off your order.
User avatar
bekateen
Posts: 7178
Joined: Tue Sep 09, 2014 5:50 pm
I've donated: $40.00!
My articles: 4
My images: 76
My cats species list: 111 (i:37, k:46)
My aquaria list: 29 (i:13)
My BLogs: 36 (i:125, p:1867)
My Wishlist: 39
Spotted: 136
Location 1: USA, California, Stockton
Location 2: USA, California, Stockton
Contact:

Re: Add new or undescribed species function is broken

Post by bekateen »

Hi Jools,

I can tell you're making progress. Today I tried it again (as a lark) and obtained this error:
Fatal error: Uncaught Error: Call to undefined function get_family_from_id() in /home/webcat/planetcatfish.com/admin/functions/add_species.php:53 Stack trace: #0 /home/webcat/planetcatfish.com/admin/classes/add_new_species.php(61): add_species('microglanis aff...', false, NULL) #1 /home/webcat/planetcatfish.com/admin/index.php(352): add_new_species->submit(Object(phpbb\db\driver\factory)) #2 /home/webcat/planetcatfish.com/admin/index.php(298): arn_admin_guts('ans', Object(phpbb\db\driver\factory), Object(phpbb\user), '5.2.1') #3 {main} thrown in /home/webcat/planetcatfish.com/admin/functions/add_species.php on line 53
Cheers, Eric
Image
http://youtube.com/user/Bekateen1
Would you like to buy my fish? Click HERE for prices.
Buying caves from https://plecocaves.com? Plecocaves is now sponsoring Bekateen's Fishroom. Use coupon code "bekateen" (no quotes) for 15% off your order.
User avatar
Jools
Expert
Posts: 15191
Joined: Mon Dec 30, 2002 3:25 pm
My articles: 193
My images: 914
My catfish: 239
My cats species list: 89 (i:0, k:6)
My aquaria list: 2 (i:2)
My BLogs: 7 (i:5, p:194)
My Wishlist: 20
Spotted: 985
Location 1: M8
Location 2: Scotland
Interests: All things aquatic, Sci-Fi, photography and travel. Oh, and beer.
Contact:

Re: Add new or undescribed species function is broken

Post by Jools »

Hi Eric,

Thanks for noticing. It's a one of those "I can't deliver the spare part to fix the machine because the road is broken" type problems. I made a significant change in the background to how new species are created. So, now, you can't create a new species if that taxon exists as a synonym anywhere (e.g. in another family or even order) however, the code is so complex I basically need to rewrite it. This process is called refactoring and I do a lot of it! The basic "add a new species" code was written around 2005, by me, so it's not that brilliant and has a lot of duplication and non-standard bits in it.

I hope to get this up and running in a matter of days.

Cheers,

Jools
User avatar
bekateen
Posts: 7178
Joined: Tue Sep 09, 2014 5:50 pm
I've donated: $40.00!
My articles: 4
My images: 76
My cats species list: 111 (i:37, k:46)
My aquaria list: 29 (i:13)
My BLogs: 36 (i:125, p:1867)
My Wishlist: 39
Spotted: 136
Location 1: USA, California, Stockton
Location 2: USA, California, Stockton
Contact:

Re: Add new or undescribed species function is broken

Post by bekateen »

Hi Jools.

This function is working for me. If you're finished recoding it, I'd think it's resolved.

Thanks, Eric
Image
http://youtube.com/user/Bekateen1
Would you like to buy my fish? Click HERE for prices.
Buying caves from https://plecocaves.com? Plecocaves is now sponsoring Bekateen's Fishroom. Use coupon code "bekateen" (no quotes) for 15% off your order.
Post Reply