Page 1 of 1

COTM bugs

Posted: 23 Jun 2006, 13:55
by MatsP
Good things first (according to D. Carnegie: start with the positve, then tell people how they can improve the other stuff!): I like the new layout and style.

First problem:
The COTM "By popularity" list doesn't link right - it still uses the old style YYYY_MM.PHP links, which obviously doesn't get to the new style scripts...

Second problem (which may actually be non-COTM related, but I found it in COTM):
On http://www.planetcatfish.com/cotm/cotm. ... icle_id=75
the link to Shane's world described "Peckoltia vittata breeding", which doesn't seem like a good link for a "Sorubim lima" article...

--
Mats

Posted: 23 Jun 2006, 14:06
by MatsP
And a tiny nit-pick: On the Ancistrus sp(3) article, the fact that it's unidentified causes the output of "Not Described, 0", where I guess 0 is the "year" it wasn't described. Could you make a special case for "not described" and not output the zero-year variable, perhaps?

This is naturally very low priority and most other people would probably not even notice...

A side-note here: Would it make sense to link the Shane's World "Breeding Ancistrus" to the Ancistrus species...?

--
Mats

Re: COTM bugs

Posted: 25 Jun 2006, 11:13
by Jools
MatsP wrote:First problem:
The COTM "By popularity" list doesn't link right - it still uses the old style YYYY_MM.PHP links
This is now fixed, I had forgotten about this page. It now uses the central "build an article link" function along with the other pages.

Jools

PS This is REALLY useful feedback and I'm glad you like the new layout. The code behind it is still quite dirty, but it will do until I get it all off the ground.

Jools

Re: COTM bugs

Posted: 25 Jun 2006, 11:50
by Jools
MatsP wrote:Second problem (which may actually be non-COTM related, but I found it in COTM):
On http://www.planetcatfish.com/cotm/cotm. ... icle_id=75
the link to Shane's world described "Peckoltia vittata breeding", which doesn't seem like a good link for a "Sorubim lima" article...
Yes, this was a problem with an article linked from a datasheet appearing on a cotm page. I have now fixed this and, additionally, it will not show a link to a cotm page from teh datasheet if the datasheet is on a cotm page.

:-)

Jools

Posted: 25 Jun 2006, 12:13
by Jools
MatsP wrote:And a tiny nit-pick: On the Ancistrus sp(3) article, the fact that it's unidentified causes the output of "Not Described, 0", where I guess 0 is the "year" it wasn't described. Could you make a special case for "not described" and not output the zero-year variable, perhaps.
Correct, I had noticed this one, and now I have tidied it up. We love functions and so we now have a get_reference function!

Jools

Posted: 25 Jun 2006, 12:22
by Jools
MatsP wrote:A side-note here: Would it make sense to link the Shane's World "Breeding Ancistrus" to the Ancistrus species...?
It would make sense but currently the articles are linked at a species level, here you suggest something that would be best achieved by a genus level article link. That's a good idea, but must be kept as a "nice to have" enhancement for the time being.

Jools

Posted: 25 Jun 2006, 12:24
by Jools
Mats,

OK, this is now all resolved. How would you feel about going through the article pages looking for broken links in the article text? There will be lots of them and I have fixed quite a few already but I could do with another pair of eyes?

Jools

Posted: 26 Jun 2006, 12:36
by MatsP
Yeah, I'll have a slow go over them. I've got a few other things to do this week, so I'm not sure how quickly I can get through all of them, but I'll report any errors in the Bugs section...

--
Mats

Posted: 27 Jun 2006, 09:00
by Jools
MatsP wrote:Yeah, I'll have a slow go over them. I've got a few other things to do this week, so I'm not sure how quickly I can get through all of them, but I'll report any errors in the Bugs section...
That would be great, cheers,

Jools

Posted: 27 Jun 2006, 11:43
by MatsP
As you probably did see, I went through all the COTM articles. I got a bit bored with coding something that I couldn't get to work anyways, so I did that instead - and every now and again trying to get the code to work, but eventually gave up and went home.

I'll have a look at Shane's World during the next few days, probably.

--
Mats