Page 1 of 1
converter doesn't work?
Posted: 20 Apr 2012, 08:53
by sidguppy
I tried to use it; put a number in, changed the first setting to litres and the second to US gallons and nothing happened......
it should work by iself, right?
I mean, if I have to put in the last number, it would be kind of redundant.....
hitting Enter didn't help,
all i got was a white page which said "pagina verlopen" (Dutch for pagina doesn't want to cooperate at all and hits your eyes with white nothing)
Re: converter doesn't work?
Posted: 20 Apr 2012, 10:24
by MatsP
I did notice this was broken some time ago. Will have a look over the weekend.
--
Mats
Re: converter doesn't work?
Posted: 20 Apr 2012, 10:37
by Jools
@Mats
Although common code, be aware of differences between in and outside of phpBBised pages. It might work in one or the other and a fix might break the other.
Jools
Re: converter doesn't work?
Posted: 20 Apr 2012, 10:50
by MatsP
It appears to be broken on both at present. But will make sure I test both, just in case.
--
Mats
Re: converter doesn't work?
Posted: 22 Apr 2012, 01:18
by MatsP
R747 contains fix. Tests on "Cool", "Catelog" and "Forum" pages to make sure it works for all of them.
--
Mats
Re: converter doesn't work?
Posted: 27 Apr 2012, 21:33
by Jools
I've applied Mats' fix. Is it fixed for you?
@Mats, Great fix BTW, this would have taken me days to figure out and fix.
Cheers,
Jools
Re: converter doesn't work?
Posted: 27 Apr 2012, 22:27
by MatsP
Jools wrote:I've applied Mats' fix. Is it fixed for you?
@Mats, Great fix BTW, this would have taken me days to figure out and fix.
Once I got the error message (firebug is great for that!), it was mostly a case of figuring out what the right way to get the actual data was.
--
Mats
Re: converter doesn't work?
Posted: 29 Apr 2012, 18:34
by MatsP
It appears to work as far as I can tell. Ok to close?
--
Mats
Re: converter doesn't work?
Posted: 29 Apr 2012, 18:40
by sidguppy
yup, works like a charm now
;)