Page 1 of 1

'hover' to show pic?

Posted: 17 Apr 2013, 13:18
by Dave Rinaldo
http://www.planetcatfish.com/common/fam ... mily_id=13

Weren't we able to hover on a species and see a pic in the past?

Re: 'hover' to show pic?

Posted: 17 Apr 2013, 13:20
by Jools
Yes indeed, something has broken. In transit between Dublin and London at present, might not get a change to look at this until Friday...

Thanks for reporting.

Jools

Re: 'hover' to show pic?

Posted: 17 Apr 2013, 15:43
by MatsP
If I can fix this on my machine (it's currently broken here, supposedly because I have a different setup than the "official" planet [I've intentionally "broken" my setup in an effort to be able to do some more advanced work to get better "connection" between Planet and Aquatic Republic]), I will try to fix this problem too...

--
Mats

Re: 'hover' to show pic?

Posted: 17 Apr 2013, 16:50
by Jools
Cool, well, we don't normally do timescales, but let's aim for fixing this before the weekend and if not I will tackle it on Saturday (when I have come "Planet time")?

Cheers,

Jools

Re: 'hover' to show pic?

Posted: 17 Apr 2013, 16:58
by MatsP
Well, I have "normal" pictures working now on my home-system, so should just be a case of figuring out why they are not working for hover (maybe the hover craft is full of eels... http://www.youtube.com/watch?v=IN9mP2_1A-c )

--
Mats

Re: 'hover' to show pic?

Posted: 17 Apr 2013, 17:20
by Jools
I thought it was a helicopter?

Jools

Re: 'hover' to show pic?

Posted: 17 Apr 2013, 18:43
by MatsP
Jokes aside, I've identified a mistake that explains why it wasn't working. I'm just making sure the fix works, which is a problem, as the hover function seems to still be broken on my machine, but works for My Aquaria, so I guess there is some detail to be fixed...

And while I was writing this I figured out why my local setup isn't showing hover-images. R1050 "removes the eels"... R1051 fixes some of the issues on my local machine.

--
Mats

Re: 'hover' to show pic?

Posted: 17 Apr 2013, 19:47
by Jools
Ok, I will test all that and post again here to advise Dave and anyone else following our eel ridden techno babble that the darn thing is fixed.

Jools

Re: 'hover' to show pic?

Posted: 18 Apr 2013, 00:21
by Jools
Mats,

Latest changes online and I don't think this hover over issue is fixed?

Jools

Re: 'hover' to show pic?

Posted: 18 Apr 2013, 01:07
by MatsP
I think the issue with hovering now is a different problem, caused by a stray debug statement in the code I submitted earlier (and that breaks all types of "redirect family/species pages". R1053 should fix that.

--
Mats

Re: 'hover' to show pic?

Posted: 18 Apr 2013, 09:01
by Jools
This release now online but not sure it's working...

Jools

Re: 'hover' to show pic?

Posted: 18 Apr 2013, 09:02
by Dave Rinaldo
Works here!

Re: 'hover' to show pic?

Posted: 18 Apr 2013, 09:41
by Jools
Yup, seems to be good now.

Jools

Re: 'hover' to show pic?

Posted: 18 Apr 2013, 20:11
by Viktor Jarikov
Thanks all. Was not working for me either. Now it does.

Re: 'hover' to show pic?

Posted: 19 Apr 2013, 00:33
by MatsP
Viktor Jarikov wrote:Thanks all. Was not working for me either. Now it does.
Yes, this was definitely a genuine "the code is not working at all" bug. In this case, we had a variable that changed name, and in ONE place, we still used the OLD name, which didn't work. A bit like if you have two fridges, you go look in the one that usually has the milk, there's no milk, so you assume that there is no milk and you can't have cereals for breakfast. If you had known that the milk had moved to the other fridge, you would have found lots of it...

In our case, the variable with the new name was used to check if there were any pictures available for the fish - which, when you look "in the wrong place" turns out to be "no pictures" for everything.

--
Mats

Re: 'hover' to show pic?

Posted: 19 Apr 2013, 02:32
by Viktor Jarikov
IDK how you guys do it. It appears to be a spiderweb... You are the unsung heroes.

Re: 'hover' to show pic?

Posted: 19 Apr 2013, 21:54
by Jools
We just spend a few minutes here and a few minutes there. ;-)

Jools