Page 1 of 1

Unable to delete photos from "My Cats"

Posted: 08 Oct 2014, 22:36
by bekateen
I recently tried to remove a photo of one of my catfish (on the "My Cats" page) by using the "Tick to delete this image" checkbox. I was trying to remove the old photo without uploading a new photo because I don't yet have a better photo of my catfish. However the function didn't work and the old photo is still saved/visible.* I thought it might be my browser, so I tried to delete the photo in both Internet Explorer 10 and in Firefox- no luck in either browser.

Does the "Tick to delete this image" checkbox work for anybody else?

Also, is there a way to delete photos in breeding reports? While making my breeding report for one of my fish, I accidently uploaded two versions of the same photo, and I'd like to remove one of them.

Thanks, Eric
*P.S., Upon reading this post, many of you will be drawn instinctively to check out my cats' photos to see what I'm talking about - like the person who is asked, "Does this dress make my butt look fat?" (if someone asked me that, the first thing I would do is look at their butt; not to judge, but out of curiosity of course). And when you do see the photos, you will all realize what a crummy photographer I am... Please don't judge me. LOL

Re: Unable to delete photos from "My Cats"

Posted: 10 Oct 2014, 16:00
by Jools
Eric,

Thanks for posting, I will have a look at this when I get home from catcon2014 although I really do think your pictures are not as bad as you think by any means!

Jools

Re: Unable to delete photos from "My Cats"

Posted: 10 Oct 2014, 17:47
by bekateen
Jools wrote:Eric, Thanks for posting, I will have a look at this when I get home from catcon2014 although I really do think your pictures are not as bad as you think by any means!
LOL. Thanks Jools, for your graciousness.
- Eric

Re: Unable to delete photos from "My Cats"

Posted: 17 Oct 2014, 20:42
by MatsP
It is indeed broken. Thanks for reporting, as without bug reports, we often don't know that things are broken!

I will have a go at fixing now (but I expect Jools will be drinking beer, talking fish and generally enjoying himself at CatCon rather than reviewing and uploading new fixes, so it may still have to wait until after CatCon for the fix to be online - assuming I actually fix it shortly).

--
Mats

Re: Unable to delete photos from "My Cats"

Posted: 17 Oct 2014, 21:31
by MatsP
Seems like a change I made in R1351 broke this (by converting the first character in the "delete this image" message was made into a capital). Fix in R1473 + R1474 for the same fix in my_aquaria.

--
Mats

Re: Unable to delete photos from "My Cats"

Posted: 17 Oct 2014, 23:41
by bekateen
MatsP wrote:Seems like a change I made in R1351 broke this (by converting the first character in the "delete this image" message was made into a capital). Fix in R1473 + R1474 for the same fix in my_aquaria.
I know this is an international forum. The funny thing is, you're writing in English, and it still sounds like a foreign language to me. :-)
Cheers, Eric

Re: Unable to delete photos from "My Cats"

Posted: 17 Oct 2014, 23:47
by MatsP
Basically, I changed something almost exactly a year ago, that made the "delete my fish" and "delete my aquaria" images to no longer work.

I have fixed it now, and those R number things are the references to the changes in the system, so that he knows what the changes are.

--
Mats

Re: Unable to delete photos from "My Cats"

Posted: 18 Oct 2014, 00:33
by bekateen
Okay, thank you Mats. Yeah! I've successfully deleted the photo in question from the "My Cats" page. I don't know what time it is where you're at (just after midnight, I'm guessing), but if it's not the middle of the work day, I'd say you deserve a beer too. To your health!

As to the other issue I mentioned in my initial post - it's not a fix per se but more an enhancement: Is it possible to delete photos in breeding reports? While making my breeding report for one of my fish, I accidently uploaded two versions of the same photo, and I'd like to remove one of them. Currently, there is no "Tick to delete this image" checkbox for photos in breeding reports.

Thanks again, Eric

Re: Unable to delete photos from "My Cats"

Posted: 18 Oct 2014, 00:58
by bekateen
Wait, no. I was mistaken - the photo is still present. The delete photo option didn't work for me. :-( (but you can still have the beer) :-)

Re: Unable to delete photos from "My Cats"

Posted: 18 Oct 2014, 11:03
by MatsP
Right, Jools is still at CatCon, and probably busy with other things than checking that he agrees with my fix, which sits in our "Source Code Repository", not actually on the site yet.

I will have a look at removing images in the breeding reports too.

--
Mats

Re: Unable to delete photos from "My Cats"

Posted: 30 Oct 2014, 22:16
by MatsP
Jools sent a mail to say that this is now online, so should work.

--
Mats

Re: Unable to delete photos from "My Cats"

Posted: 31 Oct 2014, 06:38
by bekateen
Thanks for the diligence, but I regret to say that it still doesn't work.
Regards, Eric

Re: Unable to delete photos from "My Cats"

Posted: 31 Oct 2014, 08:37
by MatsP
Seems like we need Jools' help here - is it possible that the upload of the changes failed? It certainly works locally for me.

--
Mats

Re: Unable to delete photos from "My Cats"

Posted: 31 Oct 2014, 09:35
by Jools
MatsP wrote:Seems like we need Jools' help here - is it possible that the upload of the changes failed? It certainly works locally for me.
Looks OK locally here, so I have forced a full copy of the ./common folder online just in case something is out of whack. In short, try it again now?

Jools

Re: Unable to delete photos from "My Cats"

Posted: 31 Oct 2014, 12:42
by bekateen
It worked! Yes!!!! Thanks guys :-)
-Eric

Re: Unable to delete photos from "My Cats"

Posted: 31 Oct 2014, 12:59
by Jools
Resolved!

Jools