COTM Article viewing broken.

Post by **Birger** » 20 Nov 2011, 16:44

When using any avenue on the COTM drop down menue all links go to the most recent.

Birger

MatsP · Post by **MatsP** » 20 Nov 2011, 17:12

For me, it gives an error. I suspect Jools may be editing the code for that...

--
Mats

YouTube · Post by **Jools** » 20 Nov 2011, 17:56

MatsP wrote:For me, it gives an error. I suspect Jools may be editing the code for that...

Fixed.

Jools

YouTube · Post by **Jools** » 20 Nov 2011, 17:57

Birger wrote:When using any avenue on the COTM drop down menue all links go to the most recent.

I'm struggling to replicate this. Can you give me a click by click rundown?

Cheers,

Jools

Post by **Birger** » 20 Nov 2011, 18:09

COTM drop down menu

Click on year

Click on 2000

click on april 2000

goes to nov 2011

Does not matter what combo I use it always goes to nov 2011

Birger

Dave Rinaldo · Post by **Dave Rinaldo** » 20 Nov 2011, 18:20

Same here.

This month, By year, By family and By popularity
have same problem.

YouTube · Post by **Jools** » 20 Nov 2011, 18:48

Ah, OK, the issue is with the index page that lists everything. Will look into that shortly.

Jools

unblinded · Post by **unblinded** » 21 Nov 2011, 17:42

When I attempt to view this article "2008, October Liosomadoras oncinus Jaguar Catfish" I am taken to the October 2011 article for Rita chrysea. Looks like it is doing it no matter the COTM article I try to look at.

MatsP · Post by **MatsP** » 21 Nov 2011, 17:53

Can confirm that it's broken. I will see if I can spot something obvious. In talking to Jools the other day, sounded like he's going to be busy for a few days.

--
Mats

MatsP · Post by **MatsP** » 21 Nov 2011, 21:01

Simple bug found & fixed.

@Jools: R610 [WARNING! R609 has special needs, see e-mail!]

--
Mats

mpedersen · Post by **mpedersen** » 22 Nov 2011, 04:10

I'm finding that any catfish of the month link takes a user to the October 2011 article, so from where I sit, this bug is alive and well.

Post by **Birger** » 22 Nov 2011, 04:13

I'm finding that any catfish of the month link takes a user to the October 2011 article, so from where I sit, this bug is alive and well.

Most likely Mats fixed it but it will not be implemented until Jools puts it through.

Birger

MatsP · Post by **MatsP** » 22 Nov 2011, 08:14

Birger wrote:
I'm finding that any catfish of the month link takes a user to the October 2011 article, so from where I sit, this bug is alive and well.
Most likely Mats fixed it but it will not be implemented until Jools puts it through.

Birger

Indeed. Only Jools can upload the code to the actual site. I have provided Jools with a fix, but until it's uploaded to the site, it's not actually fixed. This is also why it's not been moved to "All resolved issues".

--
Mats

MatsP · Post by **MatsP** » 22 Nov 2011, 09:49

I've merged the two reports on the same problem.

--
Mats

sidguppy · Post by **sidguppy** » 23 Nov 2011, 20:16

ALL links in the list of CotM's go to the most recent entry.......

I tried reading a few older articles and all the links go to the newest

also, i tried to go from the catelog page of Synodontis granulosa and Corydoras sterbai to the CotM article covering that species and the same happened

we all end up at Rita chrysea

MatsP · Post by **MatsP** » 23 Nov 2011, 20:21

Yes, it's a known problem, there is already a bug for it, so I've merged all three reports together.

I have provided Jools with a fix, but he's been busy the last few days and not had time to upload it.

--
Mats

MatsP · Post by **MatsP** » 23 Nov 2011, 20:24

I also edited the title to make it more obvious that it's one problem for all COTM articles (the problem is that it's not picking up the "which artcile to view" correectly, thinking it has not been specified, which means that it thinks it should use the latest).

--
mats

Post by **Marc van Arc** » 24 Nov 2011, 18:30

I would like to add that the current article gets every single hit for any CotM, which means that it has been "viewed" 6900+ times by now.....

MatsP · Post by **MatsP** » 24 Nov 2011, 18:38

That's probably the accurate number of views it's had - perhaps a little inflated due to people viewing it when they meant to view something else, but it's not on the "top 100" in popularity, and the top of the leader board has about 25000 views.

--
Mats

Post by **Marc van Arc** » 24 Nov 2011, 22:29

MatsP wrote:That's probably the accurate number of views it's had - perhaps a little inflated due to people viewing it when they meant to view something else

I bet you this "little" inflation is at least 70%, based on the numbers of other CotM's (L-numbers and probably Cories excluded).

MatsP wrote: and the top of the leader board has about 25000 views.

Which was reached in how many years?

MatsP · Post by **MatsP** » 24 Nov 2011, 23:51

Marc van Arc wrote:
MatsP wrote:That's probably the accurate number of views it's had - perhaps a little inflated due to people viewing it when they meant to view something else
I bet you this "little" inflation is at least 70%, based on the numbers of other CotM's (L-numbers and probably Cories excluded).

Ah, but the "hits" as shown at the bottom of the page isn't hits on the COTM page, but hits on the Cat-eLog page that shows the species information (which is around 5 years old and 7000 hits isn't unrealistic). Unfortunately, I can't find a way to see the number of hits for the COTM page itself.

MatsP wrote: and the top of the leader board has about 25000 views.
Which was reached in how many years?

6 years, and it's almost 29000, for L204.

--
Mats

Post by **Marc van Arc** » 25 Nov 2011, 09:07

MatsP wrote:Ah, but the "hits" as shown at the bottom of the page isn't hits on the COTM page, but hits on the Cat-eLog page
Rita chrysea
that shows the species information (which is around 5 years old and 7000 hits isn't unrealistic). Unfortunately, I can't find a way to see the number of hits for the COTM page itself.

And that's of course 10 points for you. My bad, sorry for that.

MatsP · Post by **MatsP** » 25 Nov 2011, 09:16

Marc van Arc wrote:And that's of course 10 points for you. My bad, sorry for that.

No worries. I'd rather have a few false bug reports, than someone NOT reporting a real problem.

--
Mats

YouTube · Post by **Jools** » 25 Nov 2011, 10:03

Thanks for the fix Mats but it didn't appear to work. However, there was one misspelling (ny me) of the variable article_id (as artice_id) which was the issue; the principle issue with links all going to the current CotM is fixed. There are a few tidy up activities (not least the hit counter issue) and I will attend to them soon.

For Mats - part of that is getting the update hit counter stuff into the forum framework. I'll do this over the next couple of days.

Let's keep this one unresolved until that's done?

Cheers,

Jools

MatsP · Post by **MatsP** » 25 Nov 2011, 19:32

Jools wrote:Thanks for the fix Mats but it didn't appear to work. However, there was one misspelling (ny me) of the variable article_id (as artice_id) which was the issue; the principle issue with links all going to the current CotM is fixed.

Ah, sorry, missed that - and I couldn't test it, because I have no COTM articles on my machine...

Re: hit counters, anything I can do - or will it take more time to explain it than to fix it?

--
Mats

YouTube · Post by **Jools** » 25 Nov 2011, 19:38

You could help Mats by just making the cotm.php code that's commented out work as (two? one?) new function within the forum framework.

The first bit (increment article hits) is crying out for a function (inc_article_hits?) as its used by all article pages. The second bit (the inc_contributor _hits) function just needs moved into common. There is a strong argument we only need one function that is passed table and counter field...

I am fixing an OLD problem with zebrapleco.com tonight and then it's on to getting the email alerts alerting!

You may also wish to consider "forumising" the cotm/index.php page.

Cheers,

Jools

MatsP · Post by **MatsP** » 25 Nov 2011, 19:48

Ok. Will have a go. Probably not until tomorrow, as I'm doing some sort of combined drowning sorrows and celebrating the fact that me and my wife has an agreement on the finances. I've lost a bit of my Swedish savings, but not as much as it could have been. And I will get a fair bit of the house proceeds when it's sold - in 2024 or so.

But I also have to pay out another bit of money each month - but not as bad as it could have been there either.

--
Mats

YouTube · Post by **Jools** » 25 Nov 2011, 19:51

MatsP wrote:drowning sorrows and celebrating

Probably best not to code!

Have one for me.

Jools

Martin S · Post by **Martin S** » 25 Nov 2011, 23:52

Jools wrote:
MatsP wrote:drowning sorrows and celebrating
Probably best not to code! Have one for me.

Jools

And me too! :0)

Dave Rinaldo · Post by **Dave Rinaldo** » 27 Nov 2011, 19:39

At this time I am getting.....

[phpBB Debug] PHP Warning: in file /home/webcat/planetcatfish.com/cotm/cotm.php on line 36: require_once(../includes/new_functions/article_image_parse.php) [function.require-once]: failed to open stream: No such file or directory

Fatal error: require_once() [function.require]: Failed opening required '../includes/new_functions/article_image_parse.php' (include_path='.:/usr/local/lib/php:/usr/local/php5/lib/pear') in /home/webcat/planetcatfish.com/cotm/cotm.php on line 36