Image data table broken when adding images...

[MatsP]

When adding an image under certain conditions, the table appears to go wrong. This shows itself by having a "next" arrow that leads to a "no image" ("Hacking attempt")

The conditions for this is:
1. The image is not added last - so we replace an existing image.
2. The OLD image of that position is placed in a position not the last image.

My theory is that there are TWO images with the same ID.

In the S. camelopardalis:
http://www.planetcatfish.com/catelog/sp ... ies_id=225

You can actually see that it's got TWO identical images, both with the number 2.

This causes the image with number 5 to be in position 6, and the script thinks there is another image, but we're already at the end of the list.

[Not saying "I told you so", but I think this is what I tried saying when I was code-reviewing for the "uber-bug"].

--
Mats

[MatsP]

Jools, do you believe this to be fixed now? [I haven't tried it lately].

--
Mats

[Jools]

I do think I have fixed this. However there are four paths through the code, so I may have fixed one or more of those paths but not all four. However I may have fixed them all, it was tested the wrong side of midnight.

Use it, but pay attention to the results and report here? I will see if I have images to add to test also.

Jools

[Jools]

Move to resolved as this really does look fixed now.

Jools