my aquaria wipes all data?

[MatsP]

I tried adding a picture of my new Black lancer. Because the image was "too big", it refused it, and brought me back to a "default values". Annoying - not that I had entered much data.

--
Mats

[sidguppy]

couldn't get the title in

but the problem is this:
it won't save my data!
if i use the button down right to edit & save, it returns to me with a lot of red lettering jabbering about wrong length or food missing and everything I already added is gone

after a few tries of that my patience ran out and i closed the page.

now I still don't have ANY data at all there and I'm damn sure i put in a lot about filtration, dimensions of the tank, waterparameters etc

a bug?

[Jools]

I don't think this is a bug but it might be. Certainly it is crap design and I would say we need to make it better and quickly.

What happens is if you have entered something invalid, then click save, then what you've entered is not saved as you would reasonably expect.

Jools

[MatsP]

I have reported this a long time back - I'll merge the two threads.

And I think it can be solved, but I think it needs a bit of javacode - I think it can be made into a function tho'.

--
Mats

[sidguppy]

tnx guys

Jools, what you described is exactly what happened

it went bust when it didn't accept "food" and I tried finding that list it went on about.

[Jools]

And I think it can be solved, but I think it needs a bit of javacode - I think it can be made into a function tho'.

It's to do with properly using the $_SESSION superglobal properly. Anyway, let's take the techie discussion offline. I will postpone the CotM and forum upgrade to look at this.

Jools

[sidguppy]

tried again tonight and everything went fine...

until!

until I tried to add food!

the thingamajig keeps badgering me with this message

Food category not selected. When the food appears correctly in the list, please select from the list.

but there IS NO list
neither does one appear

sometimes it gives examples, but when i select one and hit that to accept it (for example "frozen and dry" it still keeps displaying the red warning and stubbornly refuses to cooperate still
so far i cannot make it accept any foods whatsoever.

either it's bugged
OR it's quite confusing to work around or with and needs a bit more explaining how the thing can be made to work

simply typing in anything doesn't work at all, i'm afraid

the upside: at least the red warning doesn't wipe all my other data on that tank, which it did before
phew
;)

[Jools]

either it's bugged
OR it's quite confusing to work around or with and needs a bit more explaining how the thing can be made to work

Yeah, OR it might be both buggy AND hard to use. Mats is doing some work on this and once I've got a few other things looked at, I will review - I think I might also do a video on it explaining how it works.

Jools

[MatsP]

Right, so there are TWO bugs:
1. You can't actually select foods in the drop-down menu, which is in another report here:
http://www.planetcatfish.com/forum/view ... 36&t=33857

2. When something goes wrong, leading to an error message, the data entered in other fields is reset back to the "empty" value. I believe this is a completely separate problem that can be fixed separately from the other one [and for the time being, I think I'll also supply a fix that says "Food selection doesn't work right now, we're working on fixing it..."]

There may also be a usability issue, where it's not clear what you should do/how it's meant to work, for those who haven't had a hand in coming up with the system overall.

--
Mats

[Jools]

Hey Mats,

Although all I've got left in me tonight is colouring in some transparent gifs, I think this is the next thing to get some attention.

Are you working the loss of data issue or me?

Cheers,

Jools

[MatsP]

I haven't done anything today. However, I have LOTS of small changes all over the My Aquaria, and I'm worried if you make changes, we'll have "merge nightmare" at some point..

I'll have a Coke and take a look.

--
Mats

[MatsP]

Fixed, I think. Added a call to "session_start()" at the beginning of the my_aquaria.php script.

Rev. 492 + 493.

--
Mats

[Jools]

I've checked these changes and made live. It worries me such a fundamental thing was missed (or, rather, that I've taken it out from some good reason in the past). But its now live along with all the tidy-up stuff and removed redundant functions.

Great work! That was a 1am special!

Jools

[MatsP]

Since I raised the original one, I just tried updating one of my aquaria with an incorrect "High" pH value, and a text update to see that it's not loosing those edits. It seems to work fine. Thus, I declare this fixed.

--
Mats