Another funny character complication...

[MatsP]

Guyanancistrus sp(l317)

has one owner, "AM&e". It is not possible to see what other fish this user keeps, because the "URL parser" gets it wrong due to the & seen as a separator.

Using Am%26e shows the fish of the user...

--
Mats

[MatsP]

This still needs fixing.

--
Mats

[MatsP]

I'm looking into fixing this...

--
Mats

[MatsP]

Ok, got some progress, but it's not working all the way, so will continue tomorrow.

--
Mats

[MatsP]

I tried fixing this, but I couldn't quite make it work. I will work more on it.

--
Mats

[MatsP]

Fix in R492 + R493. However, my_blog and my_fish needs fixing too.

Edit: Alos, for this to work, it requires a change to forum/functions.php, which I haven't submitted!

--
Mats

[Jools]

Edit: Alos, for this to work, it requires a change to forum/functions.php, which I haven't submitted!

Yikes. OK, that one needs to be documented like other forum mods with lots of white space around the change. It is also helpful to keep in the original phpBB code in a comment in case it gets altered over time.

Cheers,

Jools

[MatsP]

The other solution is to not pass the user-name around to the My Aquaria/My Cats/My Blog, but us a (unique throughout AR) integer ID. (Problem is that usernames can contain & - which gets chopped off when we get the useranme from the URL as that's the "sign" of another parameter...

I think the change is in an "PC addition already" section, so it shouldn't really be that much of a change.

--
Mats

[Jools]

Or:

Disallow user names with an & in them at source + one off removal of them site wide.

Use an MD5 hash as the integer.

Have a function that just replaces & with something safe everywhere.

Jools

[MatsP]

I have written a function that replaces the & with %26 (and % with %25), called enconde_for_url (and decode_from_url to convert it back).

--
Mats

[Jools]

Yeah, I though that. But it's all a one function right? So we could choose other translations in future?

Jools

[MatsP]

Yes, one function to "encode" and one for "decode". See common/functions/encode_for_url.php, and yes, it's pretty easy to extend (and it uses the standard %xx method used by many web-sites to encode characters in the URL.

--
Mats

[MatsP]

And the functions.php changes are in R496. Aside from the "require_once" at the beginning of the file, it's all withing existing "pc" specific bits.

I think I need to change the code that goes on the side of the posts too, tho'.

--
Mats

[MatsP]

Hmm. Seems to not be working, although it was working a few minutes ago...

--
Mats

[Jools]

Latest version now online (and thanks for the cotm image fix - I forgot that this month, first time ever!). Is this now resolved?

Jools

[MatsP]

I suspect the admin control panel won't work for you...

But if you put a $phpBB_root in the "functions.php".

--
Mats

[Jools]

But if you put a $phpBB_root in the "functions.php".

I don't really understand this - can we pick it up by email and resolve this topic?

Jools

[MatsP]

I'll have a fix by tonight, so will let you know.

--
Mats

[MatsP]

R. 499 contains fix to allow including from the correct location whereever "functions.php" is included.

I will have further fixes for the my_* bits later on (mainly waiting for a reply to an e-mail regarding something I spotted).

--
Mats

[Jools]

R499 now online.

Jools

[MatsP]

There is still a problem when going from the Cat-eLog page to the user, and in the page that lists all owners of the species.

Fix in R516.

--
Mats

[Jools]

Fix in R516.

Online - all resolved?

Jools

[MatsP]

Yup, now resolved.

--
Mats