Typo in Breeding report Help descriptions

[krazyGeoff]

Just an easy one. In the water parameter section of the breeding report, the 'hint' for the conductivity section is the 'hint' for the hardness section

"
General Hardness: to Enter hardness range, if constant, enter the same value in both fields.

Conductivity: to Enter hardness range, if constant, enter the same value in both fields.
"
Oh and then I got this error when I set the age of the fish to blank, As per the age help

General Error
SQL ERROR [ mysql4 ]

Incorrect integer value: '' for column 'age' at row 1 [1366]

An SQL error occurred while fetching this page. Please contact the Board Administrator if this problem persists.
Please notify the board administrator or webmaster: [email protected]
Cheers

[MatsP]

Alternatively, just set the value to zero if it's blank... ;)

I will have a look over the weekend.

--
Mats

[Jools]

Mats,

Not only a bug but a blocker to good folks not tech savvy enough to understand they can use the back button, enter zero and go again. Which would be about 75% of our users I'd guess.

Thanks for looking into it. Also, I'm "on a mission" to get about 25 "bloggers" so the layout issue Mike mentioned here is improved, so more blogger = very good!

Cheers,

Jools

[krazyGeoff]

I used the back 'arrow', but it took a bit of time to identify which field it was that was causing the error as I had changed quite a bit of data (and like 99% of people I didn't actually read the error message - until just now).

Even if the hint said 'set to zero for unknown' as a temporary fix then I wouldn't have taken the zero out and replaced it with a blank, because blank / unknown / null, is not the same as zero.

Cheers

[MatsP]

I've updated some things in R645, including both of the complaints from Geoff.

--
Mats

[Jools]

I've updated some things in R645, including both of the complaints from Geoff.

R645 online now.

KrazyGeoff, can you confirm now fixed?

Cheers

Jools

[krazyGeoff]

Hi, the conductivity wording is all good. The age issue has not changed.

Cheers

[krazyGeoff]

Here is another! I'll keep putting them in here as I know Jools wants to encourage the use of the breeders log feature.

This one is the size of the Fry in the breeding section:
"
Fry sizes: 7 days: 21 days: 21 days: Use standard length (SL) in millimetres. Record largest size amongst sibling group.
"
I think the first 21 should be 14

Cheers

[MatsP]

So, it now defaults to zero, but the text says "leave blank", which does indeed give an error. I will fix the text to say "should be zero", and change the code to allow "blank" to be taken as zero.

@Jools: I added a breeding report to test this, can you delete it?

--
Mats

[Jools]

So, it now defaults to zero, but the text says "leave blank", which does indeed give an error. I will fix the text to say "should be zero", and change the code to allow "blank" to be taken as zero.

@Jools: I added a breeding report to test this, can you delete it?

--
Mats

Mats,

Is this behaviour consistent for all other fields of this type?

Jools

[MatsP]

Mats,

Is this behaviour consistent for all other fields of this type?

Jools

Good question. I think most other fields are necessary to have a value that is non-zero anyways [aside from text fields of course].

I will see if there is a good way to make these things more consistent and easy to manage.

--
Mats

[MatsP]

I _think_ R670 contains a suitable fix for this.

(I also added code to produce correct output of the "created date" on the clog-datasheet pages, and unify the look of the last update vs. created dates, and use %H:%M instead of %R, as the latter doesn't work under Windows).

--
Mats

[MatsP]

Calling KrazyGeoff: Could you verify it works better now?

--
Mats

[krazyGeoff]

Hi Mats,
All good, the zero item is fixed, and the typo's all look good too.

Cheers
Geoff

[MatsP]

It's closed then...

--
Mats